Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

city Fürth in Bavaria added #316

Merged
merged 2 commits into from
Jan 4, 2020
Merged

city Fürth in Bavaria added #316

merged 2 commits into from
Jan 4, 2020

Conversation

mojoaxel
Copy link
Member

@mojoaxel mojoaxel commented Jan 1, 2020

No description provided.

@johnjohndoe johnjohndoe requested a review from a team January 1, 2020 21:11
@johnjohndoe
Copy link
Member

@mojoaxel @ubergesundheit Please mind the Market data format specification.

@ubergesundheit
Copy link
Collaborator

Since you didn't request changes, I don't get your comment. The file looks alright to me, so I'll merge this later..

@mojoaxel
Copy link
Member Author

mojoaxel commented Jan 3, 2020

If you have anything I can improve please let me know! I did my best 😉

@johnjohndoe
Copy link
Member

... from the contribution guide:

It would also be great if you can specify the license under which the data is published as well as an update date. Both will be visible on the website so that users known how up-to-date the information is.

This would be great.

@mojoaxel
Copy link
Member Author

mojoaxel commented Jan 4, 2020

This would be great.

Done

@ubergesundheit ubergesundheit merged commit d74a3c5 into wo-ist-markt:master Jan 4, 2020
@ubergesundheit
Copy link
Collaborator

@mojoaxel awesome! It would be even more awesome, if you could advertise the added data where you can (Check out #38).

@johnjohndoe
Copy link
Member

@ubergesundheit I added Fürth to #38 so @mojoaxel can start promoting the website ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

Assignees

@ubergesundheit ubergesundheit

Labels
City: Fürth Content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojoaxel @johnjohndoe @ubergesundheit