Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Düsseldorf #96

Merged
merged 1 commit into from
May 11, 2016
Merged

Conversation

cknebel
Copy link
Contributor

@cknebel cknebel commented May 10, 2016

Hi together,
after following the rules for contributing and only using Git console, everything worked fine (I hope). So, could you please check my work? Thanks!
Best
Christian

@@ -11,6 +11,10 @@
"id": "dresden",
"label": "Dresden"
},
"düsseldorf": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is not perfect but that's not a problem. If you want to fix it:

git add cities/cities.json
git commit --amend
git push --force origin market-data-duesseldorf

@johnjohndoe
Copy link
Member

johnjohndoe commented May 10, 2016

@torfsen Looks good to me. Validator sees no errors. Feel free to merge.

@torfsen torfsen merged commit 3408d35 into wo-ist-markt:master May 11, 2016
@johnjohndoe
Copy link
Member

johnjohndoe commented May 12, 2016

@cknebel Welcome to the map 😸 Please have a look at #38. Some promotion would be very welcome. Further, I would be happy to see a tweet from you with a screenshot and a link to the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants