Email notification for flooded past-due actions #1083
Conversation
barryhughes
requested review from
a team and
jorgeatorres
and removed request for
a team
# Conflicts: # classes/ActionScheduler_AdminView.php
jorgeatorres
requested review from
a team and
Konamiman
and removed request for
jorgeatorres and
a team
There was a problem hiding this comment.
Hi @crstauf, thanks for your contribution. I have a couple of comments:
- The methods that are removed in
classes/ActionScheduler_AdminView.phpshouldn't actually be removed because they are public and the removal would break backwards compatibility. Could they be marked as deprecated, in the same way as they are indeprecated/ActionScheduler_AdminView_Deprecated.phpbelow? - While receiving the notifications via email instead of as an admin notice seems indeed like it will be useful for most people, some might prefer to continue seeing these in the admin area. So maybe a setting could be provided to choose whether to use the new email notifications, the old warning in the admin area, or both.
- Related to the above, a setting to provide an email address for the notifications (defaulting to the default admin email) would be useful.
@Konamiman I do not understand. I have defined the functions that were deprecated into the class that handles deprecated functions. Please advise.
This PR does not prevent the notice from appearing in the admin view. It seems you have not thoroughly reviewed or tested this PR? Will add some appropriate filters. |
Correct. I hadn't noticed that
Indeed I haven't tested the PR yet, I was waiting to your answer to my comment before doing that.
Perfect, thank you. Please ping me once you do that and then I'll do all the testing. |
|
@barryhughes Stalled. |
|
Added documentation, did not make name change requests. |
Closes #1080.
I suspect there will be a lot of opinions and compatibility issues here, so providing only as a stepping stone for the Action Scheduler team, in an attempt to help them get it out quickly (we'll see).