-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn user when using lowercase secrets #4218
base: release/v2.7
Are you sure you want to change the base?
Conversation
What does "it might not work properly" work? It should work. You just have to access it with the lower case name as you defined it. |
it might not work properly = you have to access it with the lower case name or change secret name in pipeline Fixed message in b5cf0d0 |
?!? did we not move to case sensitive iand depricate the secret key as a whole ?!? |
Yes, therefore the PR.
No, there was empty deprecation section in the linter code on |
So while I understand that you would like to have a warning, this is an enhancement and therefore shouldn't go into 2.7.x. |
I don't think this is needed as we already will have warning in 3.0 about deprecated secrets section as whole |
Follow up #3960 (comment)
Lints