Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate routes instead of anchors #4285

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Use separate routes instead of anchors #4285

wants to merge 15 commits into from
+312 −354

Conversation

qwerty287
Copy link
Contributor

first part of #3827

@qwerty287 qwerty287 added ui frontend related refactor delete or replace old code labels Nov 2, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Nov 2, 2024
@qwerty287 qwerty287 requested a review from a team November 2, 2024 14:18
anbraten
anbraten reviewed Nov 4, 2024
View reviewed changes
web/src/router.ts Show resolved Hide resolved
web/src/views/admin/AdminSettingsWrapper.vue Outdated Show resolved Hide resolved
anbraten
anbraten reviewed Nov 8, 2024
View reviewed changes
web/src/views/admin/AdminSettingsWrapper.vue Outdated Show resolved Hide resolved
web/src/views/org/settings/OrgSettingsWrapper.vue Outdated Show resolved Hide resolved
web/src/components/layout/scaffold/Tab.vue Outdated Show resolved Hide resolved
web/src/router.ts Show resolved Hide resolved
@qwerty287
Copy link
Contributor Author

@anbraten I just changed it now to use router-link instead of button to solve all the issues you had

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 left review comments

@anbraten anbraten anbraten left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty287 @anbraten @6543