Add heuristic func to set plugin workspace base for windows containers correctly

[6543]

regression of #3933

address one concern of #4274

[6543]

@cduchenoy you might verify that this works for you! :)

[woodpecker-bot]

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4286.surge.sh

[codecov]

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.10%. Comparing base (5139401) to head (125e777).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pipeline/frontend/yaml/compiler/convert.go	85.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4286      +/-   ##
==========================================
+ Coverage   27.06%   27.10%   +0.04%     
==========================================
  Files         379      379              
  Lines       27753    27769      +16     
==========================================
+ Hits         7512     7528      +16     
  Misses      19572    19572              
  Partials      669      669              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cduchenoy]

Hi,

@6543

Thank you so much !

To try it I need to build the Woodpecker server image with this patch using https://woodpecker-ci.org/docs/development/getting-started
is that it?

As a reminder, we are not devs but infrastructure people

[pat-s]

You can use the tag pull_4286.

[6543]

As a reminder, we are not devs but infrastructure people

@cduchenoy that's what build_pr_image lable is for :)

server image
agent image

[6543]

@cduchenoy did you had time to test it?

[cduchenoy]

Hi,

Sorry but I haven't been able to test yet

It is in production at our customer and testing is complicated

We are in the process of migrating our old gitea/drone stack to the forgejo/woodpecker couple

Once the infrastructure is finalized (well advanced :)) we will be able to test because our infrastructure and no longer that of a customer

We are also preparing the expected PRs and a teams notification plugin

[cduchenoy]

Hi,

I was finally able to test it works!

I had to create the agent for Windows with the patch because I had a grpc version mismatch error

The Windows docker image windows-agent can be found on docker-hub:

docker pull gecoit84/woodpecker-agent:pull_4286

Do you think you can apply the same fix for the steps command?

Indeed, for the pipeline to work you must add the parameter

...
workspace:
  base: C:\tmp

Without that

[6543]

I just had an idea witch would not require an heuristic: why not prepend C:\ directly in the docker backend if the backend itselve detects windows as an host ... 🤔 (and no letter was already added...)

[cduchenoy]

Yes it's the solution 👍

[6543]

@cduchenoy ok you might have a look at #4381 ... through I have windows container now running and might do actual testing with woodpecker on my end too now :)