Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package.swift #45

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Add Package.swift #45

wants to merge 5 commits into from

Conversation

kean
Copy link

@kean kean commented Jun 28, 2024

  • Add Package.swift
  • Update Bundle usages when SWIFT_PACKAGE is defined
  • Use Objective-C names for classes in storyboards – these don't get mangled

Instead of this (crashes):

customClass="MediaEditorThumbCell" customModule="MediaEditor" customModuleProvider="target"

It's now simply this:

customClass="WPMediaEditorThumbCell"

To test:


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants