feat: add config builder class #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
force-pushed
the
feature/configuration-builder
branch
from
3a42e24
to
22288fa
Compare
owenvoke
force-pushed
the
feature/configuration-builder
branch
from
22288fa
to
d1bb339
Compare
owenvoke
commented
Sep 25, 2024
| /** @param array<class-string<Inspection>> $inspections */ | ||
| public function withInspections(array $inspections): self | ||
| { | ||
| $this->inspections = [...$this->inspections, ...$inspections]; |
There was a problem hiding this comment.
Not sure if these should be overwriting the values, or merging. 🤷🏻
owenvoke
commented
Sep 26, 2024
| } | ||
|
|
||
| foreach ($this->inspections as $inspection) { | ||
| $services->set($inspection)->tag(Visitor::COMPILED); |
There was a problem hiding this comment.
Currently just tagging all inspections as being for the compiled schema, as we don't support original yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
This implements a new wrapper around the
ContainerConfigurator. In future, it would be nice to move to a custom solution, but for now this just simplifies the config.