Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate Minification by default #7038

Open
MathieuLamiot opened this issue Oct 17, 2024 · 2 comments · May be fixed by #7052
Open

Activate Minification by default #7038

MathieuLamiot opened this issue Oct 17, 2024 · 2 comments · May be fixed by #7052
Assignees
@Khadreal
Labels
effort: [XS] < 1 day of estimated development time epics 🔥 For large tasks or features, broken into smaller issues. needs: documentation Issues which need to create or update a documentation
Milestone
3.18

Comments

@MathieuLamiot
Copy link
Contributor

MathieuLamiot commented Oct 17, 2024 •
edited
Loading

EPIC Card

If needed, use this Github issue as the main one and create sub-tasks when grooming.
@MathieuLamiot MathieuLamiot added the epics 🔥 For large tasks or features, broken into smaller issues. label Oct 17, 2024
@camilamadronero camilamadronero added the needs: documentation Issues which need to create or update a documentation label Oct 17, 2024
@Miraeld Miraeld self-assigned this Oct 21, 2024
@Miraeld Miraeld added the effort: [XS] < 1 day of estimated development time label Oct 21, 2024
@Miraeld
Copy link
Contributor

Miraeld commented Oct 21, 2024

Scope a solution

To do this, we can change this line & this line to be 1 instead of 0.
So we'll ensure to get it enable for new users.

For the safe mode, we should consider changing these lines to be 1 as well.

Efforts

XS

@Miraeld Miraeld removed their assignment Oct 21, 2024
@remyperona
Copy link
Contributor

LGTM

@Khadreal Khadreal self-assigned this Oct 22, 2024
Khadreal added a commit that referenced this issue Oct 22, 2024
@Khadreal
✨ Change js/css value to 1 -- :closes: #7038
cd1f319
@Khadreal Khadreal linked a pull request Oct 22, 2024 that will close this issue
Open
7 tasks
@piotrbak piotrbak added this to the 3.18 milestone Oct 23, 2024
@MathieuLamiot MathieuLamiot mentioned this issue Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khadreal Khadreal

Labels
effort: [XS] < 1 day of estimated development time epics 🔥 For large tasks or features, broken into smaller issues. needs: documentation Issues which need to create or update a documentation
Projects
None yet
Milestone
3.18
Development

Successfully merging a pull request may close this issue.

Closes #7038 Activate minification by default wp-media/wp-rocket
7 participants
@remyperona @Khadreal @Miraeld @MathieuLamiot @piotrbak @Mai-Saad @camilamadronero