Do not serve WebP images that are larger than the original #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roy-Orbison
force-pushed
the
webp-size-check
branch
from
858e9ad
to
bd4082a
Compare
The current code assumes the .webp is always smaller, but occasionally it isn't. Optimiser plugins may report this as "already optimised" or similar.
Roy-Orbison
force-pushed
the
webp-size-check
branch
from
bd4082a
to
1f93b00
Compare
Roy-Orbison
commented
Sep 6, 2023
| @@ -435,14 +435,20 @@ private function url_to_webp( $url, $extensions ) { | |||
|
|
|||
| if ( $this->filesystem->exists( $src_path_webp ) ) { | |||
| // File name: image.jpg => image.webp. | |||
| return preg_replace( '@\.' . $src_url['extension'] . '$@', '.webp', $src_url['src'] ) . $src_url['query']; | |||
| $src_url_webp = preg_replace( '@\.' . $src_url['extension'] . '$@', '.webp', $src_url['src'] ) . $src_url['query']; | |||
| } elseif ( $this->filesystem->exists( $src_path_webp = $src_path . '.webp' ) ) { // phpcs:ignore Generic.Sniffs.CodeAnalysis.AssignmentInCondition,Squiz.Sniffs.PHP.DisallowMultipleAssignments | |||
There was a problem hiding this comment.
Assigning within the condition avoids unnecessarily nested if statements. it's not meant to be a comparison.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code assumes the
.webpis always smaller, but occasionally it isn't. Optimiser plugins may report this situation as "already optimised", or similar. In some cases, the optimiser plugin provides both a WebP version and an optimised version with the same name as the original, and the WebP might be smaller than the original but larger than the other optimised file.Description
This adds a size check to the webp URL replacer function. I noticed that Rocket was still replacing URLs for which Imagify reports "already optimised", so the images served were larger, which degraded performance.
Type of change
Is the solution different from the one proposed during the grooming?
N.a.
Checklists
Generic development checklist
Test summary
I ran this patch on a live site (with an additional logging line inside the size check
ifblock), and it worked as intended.