Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #5640: Wrong Home URL TranslatePress #6266

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Nov 10, 2023

Description

A new column is_home has been added to the our table in the database, and the logic around the creation of job has been changed.

Fixes #5640

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld self-assigned this Nov 10, 2023
@Miraeld Miraeld added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Nov 10, 2023
@Miraeld Miraeld requested review from a team and CrochetFeve0251 November 13, 2023 05:10
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Miraeld

for @wp-media/qa-team we need to test both translatepress and wpml.
Check this old issue for more details:
#5065

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Nov 17, 2023

@Miraeld Thanks for the PR. Please find exploratory test notes below:

  • The issue was not reproducible on 3.15.4. However, with the PR, the translated home language returns 404 in the used CSS. @Miraeld can you please check 🙏
    Screenshot from 2023-11-17 09-46-26
  • When updating while having already home page as completed in the used CSS, is_home will be 0 till we regenerate the used CSS for this page. @piotrbak what do you think? shall it be fixed here or is it acceptable for now?
    Screenshot from 2023-11-17 10-02-11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUCSS wrong home_url detection with TranslatePress enabled
4 participants