Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6982 Cache is not purged when the path of cache folder contains a char that is part of the regular expression syntax #6983

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Kilbourne
Copy link

Description

Fixes #6982
Fixes cache purging when the path of cache folder contains a char that is part of the regular expression syntax

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Release

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • [X ] I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@Kilbourne Kilbourne changed the title Fixes #6982 Fixes #6982 Cache is not purged when the path of cache folder contains a char that is part of the regular expression syntax Sep 19, 2024
inc/functions/files.php Outdated Show resolved Hide resolved
Co-authored-by: Rémy Perona <[email protected]>
@hanna-meda
Copy link

Hello @Kilbourne. Thank you for this PR. I reproduced the issue by renaming /wp-content to 2024-09-02T11:32:23+0000 (updated also the path for folder in wp-config) but then checking on the PR it was the same, cache files weren't purging. So I am not sure if these were the right steps to test or the issue is still not fixed. If you can have a second look. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants