Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to py3.9, test py3.12 #475

Merged
merged 26 commits into from
Oct 24, 2023
Merged

Bump to py3.9, test py3.12 #475

merged 26 commits into from
Oct 24, 2023

Conversation

dcherian
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #475 (9c47f1f) into main (e3254bd) will decrease coverage by 0.21%.
The diff coverage is 91.17%.

❗ Current head 9c47f1f differs from pull request most recent head 6aa8bd1. Consider uploading reports for the commit 6aa8bd1 to get more accurate results

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   86.30%   86.10%   -0.21%     
==========================================
  Files          22       22              
  Lines        4185     4209      +24     
  Branches      211      207       -4     
==========================================
+ Hits         3612     3624      +12     
- Misses        515      528      +13     
+ Partials       58       57       -1     
Flag Coverage Δ
mypy 38.00% <56.25%> (+0.92%) ⬆️
unittests 95.85% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cf_xarray/accessor.py 85.99% <100.00%> (-0.47%) ⬇️
cf_xarray/criteria.py 99.06% <100.00%> (+<0.01%) ⬆️
cf_xarray/formatting.py 76.66% <100.00%> (-0.26%) ⬇️
cf_xarray/geometry.py 88.33% <100.00%> (ø)
cf_xarray/helpers.py 65.81% <100.00%> (ø)
cf_xarray/options.py 92.59% <100.00%> (+0.28%) ⬆️
cf_xarray/scripts/make_doc.py 96.42% <100.00%> (ø)
cf_xarray/utils.py 89.18% <100.00%> (+0.14%) ⬆️
cf_xarray/tests/test_accessor.py 94.06% <80.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

@dcherian
Copy link
Contributor Author

dcherian commented Oct 24, 2023

myst-nb only supports py3.10. I think this is why I was getting weird behaviour?

Don't know but by moving myst-nb to doc.yml, we now get a consistent environment at least.

@dcherian dcherian merged commit c4d662e into main Oct 24, 2023
12 of 13 checks passed
@dcherian dcherian deleted the drop-py38 branch October 24, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant