Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement loc #79

Merged
merged 11 commits into from
Mar 9, 2021
Merged

implement loc #79

merged 11 commits into from
Mar 9, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Mar 4, 2021 •
edited
Loading

@keewis keewis mentioned this pull request Mar 4, 2021
Closed
8 tasks
@keewis
Copy link
Collaborator Author

keewis commented Mar 9, 2021

we will need to think about a way to raise a KeyError from the DimensionalityError raised by convert_units, but I guess that's something we can figure out when we complete #43.

@keewis keewis merged commit 038ac60 into xarray-contrib:master Mar 9, 2021
@keewis keewis deleted the loc branch March 9, 2021 13:58
@keewis keewis mentioned this pull request Mar 15, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keewis