Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attributes being dropped in certain circumstances #54

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Fix attributes being dropped in certain circumstances #54

merged 4 commits into from
Nov 15, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Nov 14, 2024

Whenever format_lat is triggered and extrapolates data to the poles, the attributes were being dropped.

@BSchilperoort
Copy link
Contributor

Thanks for fixing this, Ben!

Could you update the changelog and add yourself to the CITATION.cff file?

@maresb
Copy link
Contributor Author

maresb commented Nov 15, 2024

Done, thanks @BSchilperoort!

@BSchilperoort BSchilperoort merged commit 1425e13 into xarray-contrib:main Nov 15, 2024
11 checks passed
@maresb maresb deleted the fix-dropped-attrs branch November 15, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maresb @BSchilperoort