fix: correct whitening in HilbertCPCCA models #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the data preprocessing of the Hilbert CPCCA model the data was first whitened and then Hilbert transformed. The final Hilbert transform destroyed the whitening property of the data. The correct order should be Hilbert transform -> Whitening.
In order to fix this we refactor the
Whitener
into two classes, aPCA
preprocessor and a pureWhitener
. Then we move the data augmentation step in between thePCA
andWhitener
step.