Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to optionally return distances with .sel #41

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Changes to optionally return distances with .sel #41

wants to merge 14 commits into from

Commits on Jan 19, 2023

  1. Changes to optionally return distances with .sel 

    Changes include:
* accessor optionally takes in a "distances_name" str with which to name the new variable in results to store calculated distances from query()
* query() now returns distances
* distances are returned (always?) in radians from the trees, but are converted to kilometers in query.
* If a DataArray was input to .sel with "distances_name" input, a Dataset will be returned to contain the new variable
* added example to intro notebook
* added a test to test_accessor
* also fixed an import in conftest

Notes:
* I did not test this with the dask approach
    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    d2b4542 View commit details
    Browse the repository at this point in the history

  2. got precommit 

    needed some updates in precommit too
    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4f3ecc6 View commit details
    Browse the repository at this point in the history

  3. realized I should add some attributes

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    88fadb7 View commit details
    Browse the repository at this point in the history

  4. recently have been issues with mamba 

    conda-incubator/setup-miniconda#274 (comment)
    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    e7e6429 View commit details
    Browse the repository at this point in the history

  5. had more lint from changes

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    9e693de View commit details
    Browse the repository at this point in the history

  6. trying building docs with mamba

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    77acd76 View commit details
    Browse the repository at this point in the history

  7. another readthedocs change

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    524d791 View commit details
    Browse the repository at this point in the history

  8. rearranged and matched distances shape to dims

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    7ce86c6 View commit details
    Browse the repository at this point in the history

  9. forgot lint again

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    70d00b3 View commit details
    Browse the repository at this point in the history

  10. found a nuance while using code

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f8bc246 View commit details
    Browse the repository at this point in the history

  11. figured out a better way to shape distances from the code

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    611607c View commit details
    Browse the repository at this point in the history

  12. changed multiplication to km not meters divided by 1000

    @kthyng
    kthyng committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c8c3411 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. updates due to comments from benbovy

    @kthyng
    kthyng committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e58322e View commit details
    Browse the repository at this point in the history

  2. updates for willirath

    @kthyng
    kthyng committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    40a9ba2 View commit details
    Browse the repository at this point in the history