Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dark-theme hack on next Xarray release #74

Open
kmpaul opened this issue Apr 19, 2022 · 0 comments · May be fixed by #94
Open

Remove dark-theme hack on next Xarray release #74

kmpaul opened this issue Apr 19, 2022 · 0 comments · May be fixed by #94

Comments

@kmpaul
Copy link
Contributor

kmpaul commented Apr 19, 2022

What is your issue?

With the merging of pydata/xarray#6501 and the closing of pydata/xarray#6500, the hack for Xarray HTML reprs in the Furo Sphinx theme (implemented in #72) should no longer be needed. I don't believe that it will cause problems if it remains, but if it is no longer needed, I believe it should be removed.

The easiest way of satisfying this need is to simply remove the docs/_static/custom.js file and references to it in docs/conf.py.
@kmpaul kmpaul mentioned this issue Apr 19, 2022
Closed
@jthielen jthielen added this to the v0.0.2 milestone Sep 9, 2022
@jthielen jthielen linked a pull request Sep 9, 2022 that will close this issue
Draft
1 task
@jthielen jthielen removed this from the v0.0.2 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dark-theme hack given upstream fix jthielen/xwrf
2 participants
@jthielen @kmpaul