Add docstrings #187
Add docstrings #187
Conversation
| @@ -11,6 +11,8 @@ | |||
|
|
|||
|
|
|||
| class AddonDependency(): | |||
| """Get the version of the current addon | |||
There was a problem hiding this comment.
But if you look at the code it's getting the version from the xml file
There was a problem hiding this comment.
It is reading the minum version of the dependency from an ET.Element.
mzfr
force-pushed
the
pylint-fixes
branch
2 times, most recently
from
5dc3995
to
3b4a7e5
Compare
kodi_addon_checker/addons/Addon.py
Outdated
| @@ -12,6 +12,8 @@ | |||
|
|
|||
|
|
|||
| class Addon(): | |||
| """Returns all the dependencies of an addon | |||
There was a problem hiding this comment.
The class doesn't return anything. Also id and version are safed too.
| @@ -11,6 +11,8 @@ | |||
|
|
|||
|
|
|||
| class AddonDependency(): | |||
| """Get the version of the current addon | |||
There was a problem hiding this comment.
It is reading the minum version of the dependency from an ET.Element.
| @@ -115,6 +115,18 @@ def _validate(xml, schemapath): | |||
|
|
|||
|
|
|||
| def check_version(branch_name, schema_file): | |||
| """Check whether the schema files for the specific | |||
| branch exists or not and if not then return the | |||
| highest available variant of the schema file | |||
|
@Rechi are we using some specific format for docstrings? If not I would like to recommend REST format. |
|
@mzfr I noticed that some already existing docstrings are uniform. For eg:in main.py |
Fixes #179
I haven't added docstring to any method/class that doesn't have any code in it(not sure what to write in them).