Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulse buffer fixes #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pulse buffer fixes #8

wants to merge 3 commits into from

Commits on Feb 14, 2019

  1. pulse: fix possible overflow for buffer_time option 

    The int cast is wrong and unnecessary as internal->buffer_time is a
pa_usec_t (which is uint64_t). It does not even make sense to cast
it to a uint as it being multiplied by the sample rate (and then
divided by 1000000 before it get fitted into battr.tlength, which
is a uint32_t).

Also ditch the "+7" trick for format->bits as the function would
have returned already if it isn't 8/16(/24).
    @tomty89
    tomty89 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    e46ea83 View commit details
    Browse the repository at this point in the history

  2. pulse: set battr.minreq and battr.maxlength to -1 

    We really just want to set battr.tlength (as its default is 2s).
It's better to left the others for pulse to determine.
    @tomty89
    tomty89 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    684c302 View commit details
    Browse the repository at this point in the history

  3. pulse: avoid unnecessary calculation

    @tomty89
    tomty89 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    6872758 View commit details
    Browse the repository at this point in the history