Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internals #2689

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactor internals #2689

wants to merge 5 commits into from

Commits on Mar 30, 2021

  1. Factor out the lookahead computation out of send_frame 

    Preliminary to the by_gop encoding refactor.
    @lu-zero
    lu-zero committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ed53c21 View commit details
    Browse the repository at this point in the history

  2. Move the lookahead computation in the receive_packet 

    And update the channel-api similarly.
    @lu-zero
    lu-zero committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    6f47f2c View commit details
    Browse the repository at this point in the history

  3. Do not use the frame_q 

    FrameData.fs contains already the input frame, take a reference from it.
    @lu-zero
    lu-zero committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    393d22c View commit details
    Browse the repository at this point in the history

  4. Do not compute the qi if it not going to be used

    @lu-zero
    lu-zero committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9626214 View commit details
    Browse the repository at this point in the history

  5. Explicitly skip processing non-valid frame invariants

    @lu-zero
    lu-zero committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    53fc05b View commit details
    Browse the repository at this point in the history