Adjust lang.reflection.Type::package() to return Package() for global…

… classes
xp-framework · Mar 28, 2024 · b472246 · b472246
1 parent 043dd55
commit b472246
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/main/php/lang/reflection/Type.class.php b/src/main/php/lang/reflection/Type.class.php
@@ -83,13 +83,12 @@ public function is($type): bool {
   }
 
   /**
-   * Returns this type's package, or NULL if this type is in the global namespace.
+   * Returns this type's package
    *
-   * @return ?lang.reflection.Package
+   * @return lang.reflection.Package
    */
   public function package() {
-    $name= $this->reflect->getNamespaceName();
-    return $name ? new Package($name) : null;
+    return new Package($this->reflect->getNamespaceName());
   }
 
   /**

diff --git a/src/test/php/lang/reflection/unittest/TypeTest.class.php b/src/test/php/lang/reflection/unittest/TypeTest.class.php
@@ -51,7 +51,7 @@ public function package() {
 
   #[Test]
   public function global_namespace() {
-    Assert::null(Reflection::of(\Throwable::class)->package());
+    Assert::equals(new Package(), Reflection::of(\Throwable::class)->package());
   }
 
   #[Test]