Taskfile: Download and set up Meteor.js as part of building the package; Refactor tarball download and extraction into reusable task.

[junhaoliao]

References

1. Meteor official install script: https://install.meteor.com/
2. Purpose of .meteor-portable

Description

1. Taskfile: Add Meteor setup task in Taskfile.yml.
2. Remove Meteor setup steps from GitHub workflow.
3. Refactor Taskfile and lint-tasks.yml to extract common download and extract task.
4. Remove temp files resulted from meteor build before checksum.

Validation performed

1. Started with a clean Ubuntu 20.04 WSL installation.
2. Installed Docker Engine following instructions at https://docs.docker.com/engine/install/ubuntu/ .
3. Ran docker image ghcr.io/y-scope/clp/clp-core-dependencies-x86-ubuntu-focal:main .
4. Installed Go Task following instructions at https://taskfile.dev/installation/#install-script . Note the "Install Script" approach is taken to avoid installing any Node.js dependencies.
5. Built the CLP package with command:

   cd <clp-repo>
   task
   

   Observed the build is successful.
6. Re-ran command task and observed no tasks are getting unnecessarily re-built:

   > task
   task: Task "package-venv" is up to date
   task: Task "core-submodules" is up to date
   task: Task "core" is up to date
   task: Task "clp-package-utils_venv" is up to date
   task: Task "clp-py-utils_venv" is up to date
   task: Task "job-orchestration_venv" is up to date
   task: Task "clp-package-utils" is up to date
   task: Task "clp-py-utils" is up to date
   task: Task "job-orchestration" is up to date
   task: Task "Download & Extract node-v14.21.3-linux-x64.tar.xz" is up to date
   task: Task "Download & Extract meteor-bootstrap-os.linux.x86_64.tar.gz" is up to date
   task: Task "webui-node-modules" is up to date
   task: Task "webui" is up to date
   task: Task "package" is up to date
   

7. Ran linting config:

# Task `lint:js-check` will also be run, which invokes `linter-nodejs`
task lint:check

And observed success.
11. Deleted <clp-repo>/build/meteor.md5 and ran task. Observed tasks "Download & Extract meteor-bootstrap-os.linux.x86_64.tar.gz" getting rebuilt.

[junhaoliao]

Refactoring and validating in progress. Let's put this review on hold.

[kirkrodrigues]

This is neat. Some refactoring comments mostly.

[junhaoliao]

@haiqi96 I noticed we have this platform attribute for task webui. Does it mean the task only runs on x86 platforms? Now that we also set up the arch-specific meteor and nodejs, do we still need the restriction here? (My insights are limited as I'm not too sure how the webui is built currently for your workflow

[kirkrodrigues]

Does meteor build --architecture now support ARM platform IDs?

[junhaoliao]

Sorry for the oversight. It doesn't seem to be the case.
The aarch64 related handling was added into the install script together with the 2.14 -> 2.15 upgrade so I mistakenly thought it was available for download. https://static.meteor.com/packages-bootstrap/2.15/meteor-bootstrap-os.linux.aarch64.tar.gz just doesn't open.

ARM support is expected to be available in meteor 3.0 though.

[kirkrodrigues]

Not a big deal to leave it since we'll soon clean up the ordering of tasks, but we could move webui-nodejs after webui-node-modules to maintain an alphabetical ordering of these artifact-building internal tasks.

[junhaoliao]

Let's leave it to the future PR then. Earlier I also wanted to move task meteor to some upper position but was confused by the current ordering of the non-internal tasks.

[kirkrodrigues]

How about:

Taskfile: Download and set up Node.js and Meteor.js as part of building the package. (#363)

[junhaoliao]

Somehow GitHub's git implementation wasn't able to resolve deltas in the moved building.md, and I had to manually trigger a merge offline. Approvers please approve and trigger the merge from your end.

[junhaoliao]

How about:

Taskfile: Download and set up Node.js and Meteor.js as part of building the package. (#363)

Maybe we can give less emphasis on the Node.js setup as webui-nodejs was already there but only got refactored. How about:

Taskfile: Download and set up Meteor.js as part of building the package; Refactor Tarball download and extract into reusable task. (#363)

Feel free to revise the wording and please trigger the merge from your end.