-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clp: Add support for SQLite prepared select statement. #402
Open
LinZhihao-723
wants to merge
14
commits into
y-scope:main
Choose a base branch
from
LinZhihao-723:metadata_str_id_mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
clp: Add support for SQLite prepared select statement. #402
LinZhihao-723
wants to merge
14
commits into
y-scope:main
from
LinZhihao-723:metadata_str_id_mapping
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt code state is for sure broken.
The refactoring lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Before this PR, SQLIte prepared select statements are manually written using a format string, making it hard to get column values using a selected column name: there is no built-in way to track the column indices.
This PR implements a class to wrap SQLIte prepared select statement. It takes the column names to select, the table name to select from, and an "AND chaining"
WHERE
clause + anORDER
clause. This class maintains an internal mapping of the column indices so the caller can get column values by providing a column name.The filters in the
WHERE
clause and theORDER
clause are formatted by the caller. The caller will take care of value binding using proper placeholders.Validation performed