Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): reducing 50% of a11y issues on contributor page #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StephNathai
Copy link

@StephNathai StephNathai commented Oct 20, 2023

Description

Resolving issue #78 to make links on Yargs Contributor page accessible

Before Changes

before

After Changes

after

@shadowspawn
Copy link
Member

Thanks. Is there a particular reason you removed the trailing space but not the leading space around the link text? Otherwise, I suggest leave those changes out of this PR as both leading and trailing spaces are removed in #77.

@StephNathai
Copy link
Author

StephNathai commented Oct 23, 2023

Thanks. Is there a particular reason you removed the trailing space but not the leading space around the link text? Otherwise, I suggest leave those changes out of this PR as both leading and trailing spaces are removed in #77.

With the CSS change I've made, the trailing space needs to be removed or the links will have a trailing underlined space. Removing the leading space does not make a difference visually, but I have just pushed up another change to remove it to keep consistency. I've also attached screenshots of my local before/after changes.

Copy link
Member

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants