Convert newlines to spaces and consider the first sentence ended only if the dot is followed by a space in BaseDoc::extractFirstSentence()
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source comment: ~~~markdown a URI [RFC3986](https://tools.ietf.org/html/rfc3986) or URI template [RFC6570](https://tools.ietf.org/html/rfc6570). This property is required. ~~~ before fix `BaseDoc::extractFirstSentence()` return: `a URI [RFC3986](https://tools.` after: `a URI [RFC3986](https://tools.ietf.org/html/rfc3986) or URI template [RFC6570](https://tools.ietf.org/html/rfc6570).` is dirty fix, but covering main cases
arogachev
reviewed
Mar 28, 2022
arogachev
reviewed
Mar 28, 2022
arogachev
reviewed
Mar 28, 2022
Co-authored-by: Alexey Rogachev <[email protected]>
arogachev
reviewed
Mar 28, 2022
|
Thanks, it's actually 2 fixes in 1, also handles newlines. 👍 |
Co-authored-by: Alexey Rogachev <[email protected]>
|
@arogachev That's method still incorrect. We can detect summary only by first |
|
@WinterSilence Thanks. Moved it to a separate issue for now - #283. |
|
@WinterSilence Thanks for your contribution! 👍 I additionally checked how it affects current API docs using diffs, didn't find any regression. Need to prepare new release now. |
arogachev
changed the title
BaseDoc::extractFirstSentence()BaseDoc::extractFirstSentence()
|
@arogachev меня удивляет, что такой популярный и, вышедший много лет назад, фреймворк до сих пор настолько сырой |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source comment:
before fix
BaseDoc::extractFirstSentence()return:a URI [RFC3986](https://tools.after:
a URI [RFC3986](https://tools.ietf.org/html/rfc3986) or URI template [RFC6570](https://tools.ietf.org/html/rfc6570).is dirty fix, but covering main cases
Minor additions for historical purposes by @arogachev.
Newline (only affects HTML code, not visual output):
https://github.com/yiisoft/yii2/blob/2874e070f3ad88c727b1335ba4f4515855bf5f64/framework/base/Controller.php#L48-L52
No space after dot: