add type #364
Open
add type #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragonbuf
commented
Dec 5, 2019
Dragonbuf
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | yes |
| Breaks BC? | yes |
| Tests pass? | yes |
| Fixed issues | #363 |
samdark
reviewed
Dec 5, 2019
,if $cwd default is '',will throw new RuntimeException(sprintf('The provided cwd "%s" does not exist.', $this->cwd));
samdark
approved these changes
Dec 19, 2019
rob006
reviewed
Dec 19, 2019
There was a problem hiding this comment.
This change does not make sense to me. #363 was about lack of support symfony/process v5.x - TypeError: Argument 1 passed to Symfony\Component\Process\Process::__construct() error was fixed a long ago, but OP installed an old version of yii2-queue because of invalid composer constraints in old releases. #363 should be fixed by adjusting composer.json to allow symfony/process v5. Cast to float should not be necessary (and definitely not related to #363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.