Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the column value in batch insert for SQLite prior to 3.7.11 ver… #19937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check the column value in batch insert for SQLite prior to 3.7.11 ver… #19937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework/db/sqlite/QueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
foreach ($rows as $row) {
$vs = [];
foreach ($row as $i => $value) {
if (isset($columnSchemas[$columns[$i]])) {
if (isset($columns[$i], $columnSchemas[$columns[$i]])) {

Check warning on line 160 in framework/db/sqlite/QueryBuilder.php

View check run for this annotation

Codecov / codecov/patch

framework/db/sqlite/QueryBuilder.php#L160 

Added line #L160 was not covered by tests
$value = $columnSchemas[$columns[$i]]->dbTypecast($value);
}
if (is_string($value)) {
Expand Down
Loading