Support BackedEnum attribute typecast behaviour. #20185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20185 +/- ##
============================================
- Coverage 64.99% 64.98% -0.01%
- Complexity 11392 11394 +2
============================================
Files 430 430
Lines 36921 36925 +4
============================================
Hits 23995 23995
- Misses 12926 12930 +4 ☔ View full report in Codecov by Sentry. |
briedis
commented
Jun 4, 2024
| 'attributeTypes' => [ | ||
| 'status' => StatusTypeString::class, | ||
| ], | ||
| 'typecastBeforeSave' => true, |
There was a problem hiding this comment.
I am not sure if this is needed even, because other tests may test these different events/scenarios when the casting is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the casting approach that Laravel has implemented.
Not sure about validation, I think that should be implemented separately.