Only note spec and generator version in gemspec file #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymholt
commented
Jul 8, 2024
| @@ -23,7 +20,7 @@ Gem::Specification.new do |s| | |||
| s.email = ["[email protected]"] | |||
| s.homepage = "https://github.com/ynab/ynab-sdk-ruby" | |||
| s.summary = "YNAB API Endpoints Ruby Gem" | |||
| s.description = "Ruby gem wrapper for the YNAB API. Read the documentation at https://api.ynab.com" | |||
| s.description = "Ruby gem wrapper for the YNAB API. Read the documentation at https://api.ynab.com Generated from server specification version 1.70.0 using OpenAPI Generator version 7.6.0." | |||
There was a problem hiding this comment.
Versions are now noted once, here in the gemspec.
bradymholt
commented
Jul 8, 2024
| @@ -0,0 +1,3 @@ | |||
| This directory contains override templates for generating Ruby code from the OpenAPI spec. The modify the default behavior or the generator. | |||
There was a problem hiding this comment.
Added this README for future reference when we need to override a template.
bradymholt
changed the title
bradymholt
commented
Jul 8, 2024
| @@ -0,0 +1,9 @@ | |||
| {{#appName}} | |||
There was a problem hiding this comment.
Overriding this template is the primary change here. The original (default) version version cane be found here: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/ruby-client/api_info.mustache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than adding a comment on most generated files with the version of the spec and the version of the generator, we will note it once in the gemspec file. This will reduce the diff in future PRs while still preserving the helpful version numbers.