Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create validator object to give more validation flexibility #2484

Merged
merged 12 commits into from
Aug 2, 2023
Merged

Create validator object to give more validation flexibility #2484

merged 12 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. Create validator object to give more validation flexiability 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ad8aab5 View commit details
    Browse the repository at this point in the history

  2. Change under the hood for now to not break the API 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b638e85 View commit details
    Browse the repository at this point in the history

  3. Start with eskip.ParseFilters and fix failing tests logs 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    948e75a View commit details
    Browse the repository at this point in the history

  4. Join filters issues 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    2ed2a1c View commit details
    Browse the repository at this point in the history

  5. Fail after basic validation fails otherwise join errors 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    903ee88 View commit details
    Browse the repository at this point in the history

  6. Refactor & add more validation webhook tests 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1c374d3 View commit details
    Browse the repository at this point in the history

  7. Parse predicates eskip also 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    64b1e3e View commit details
    Browse the repository at this point in the history

  8. Update failing eskip parsing tests to indicate that it only generate … 

    …eskip in case of all valid grammer.

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8fc2946 View commit details
    Browse the repository at this point in the history

  9. Wait for go1.21 to use errors.Join for now use an adhoc wrapper 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    438a949 View commit details
    Browse the repository at this point in the history

  10. Use errorJoin for wrapping errors and keep ValidateRouteGroups na… 

    …ming

Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ceefece View commit details
    Browse the repository at this point in the history

  11. rebasing mistakes 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1eef03a View commit details
    Browse the repository at this point in the history

  12. Cleanup leftovers & typos 

    Signed-off-by: Mustafa Abdelrahman <[email protected]>
    @MustafaSaber
    MustafaSaber committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a305df3 View commit details
    Browse the repository at this point in the history