add extra tags for uploaded Postgres log files #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
force-pushed
the
pglog-upload-tags
branch
from
79c5369
to
896c89c
Compare
idanovinda
reviewed
Sep 17, 2024
idanovinda
approved these changes
Sep 17, 2024
hughcapet
approved these changes
Sep 18, 2024
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggest to add some extra tags along with the uploaded log files so that external log analyzer tools (if they are too stupid to parse the import file path) know from which database cluster, K8s namespace and AWS account the log is coming from
The account info is only injected as environment variable by our deployment tool. Therefore, I came up with the idea to make the tags configurable. One can choose keys and values should reference existing env vars.