Ensure correct bin_dir for pg params configuration #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make inplace upgrade code use the bin_dir of the proper version throught the whole process, so that ConfigHandler.write_postgresql_conf() validates provided params using the proper PG version.
hughcapet
force-pushed
the
fix/bin_dir_upgrade
branch
from
46f3e5e
to
a89ca13
Compare
Patroni caches available GUCs since 3.2.1
macedigital
reviewed
Feb 6, 2024
|
👍 |
macedigital
reviewed
Feb 14, 2024
There was a problem hiding this comment.
It took me a couple of passes to get an understanding of the changes, because the broader context of the full code base must be considered.
This pull-request should fix the failed upgrade from 10 -> 15 which triggered this PR, but I'm honestly not 100% certain all side-effects are caught.
| @@ -50,11 +52,15 @@ def get_cluster_version(self): | |||
| with open(self._version_file) as f: | |||
| return f.read().strip() | |||
|
|
|||
| def set_bin_dir(self, version): | |||
| def set_bin_dir_for_version(self, version): | |||
| from spilo_commons import get_bin_dir | |||
There was a problem hiding this comment.
Curious: Is this import inside the function because of circular dependencies?
Comment on lines
58
to
63
| self._bin_dir = get_bin_dir(version) | ||
| self._available_gucs = None | ||
|
|
||
| def set_bin_dir(self, bin_dir): | ||
| self._bin_dir = bin_dir | ||
| self._available_gucs = None |
There was a problem hiding this comment.
Was it considered to call set_bin_dir from specialized function set_bin_dir_for_version ? This could reduce chances of "drift" in the future
Suggested change
| self._bin_dir = get_bin_dir(version) | |
| self._available_gucs = None | |
| def set_bin_dir(self, bin_dir): | |
| self._bin_dir = bin_dir | |
| self._available_gucs = None | |
| self.set_bin_dir(get_bin_dir(version)) | |
| def set_bin_dir(self, bin_dir): | |
| self._bin_dir = bin_dir | |
| self._available_gucs = None |
|
👍 |
hughcapet
force-pushed
the
fix/bin_dir_upgrade
branch
from
a3625ec
to
b780f0b
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make inplace upgrade code use the bin_dir of the proper version throught the whole process, so that
ConfigHandler.write_postgresql_conf() validates provided params using the proper PG version.