Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: translation string for lookup field placeholder #521

Merged
merged 1 commit into from
Aug 29, 2024
Merged

chore: translation string for lookup field placeholder #521

merged 1 commit into from
Aug 29, 2024

Conversation

gosiexon-zen
Copy link
Contributor

Description

Translation string for lookup field placeholder. Support for Lookup fields for custom objects in the Copenhagen Theme v4 will be added soon.

Screenshots

Screenshot 2024-08-29 at 11 51 29

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@gosiexon-zen gosiexon-zen requested a review from a team as a code owner August 29, 2024 09:52
kubraokcu
kubraokcu approved these changes Aug 29, 2024
View reviewed changes
Copy link

@kubraokcu kubraokcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼🌐

@kubraokcu kubraokcu added the g11n-approved Commented by Globalization label label Aug 29, 2024
@gosiexon-zen gosiexon-zen merged commit 6edc745 into master Aug 29, 2024
5 checks passed
@gosiexon-zen gosiexon-zen deleted the mbien/lookupfield-placeholder-translation branch August 29, 2024 10:06
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubraokcu kubraokcu kubraokcu approved these changes

@Fredx87 Fredx87 Fredx87 approved these changes

Assignees
No one assigned
Labels
g11n-approved Commented by Globalization label released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gosiexon-zen @zd-svc-github-copenhagen-theme @Fredx87 @kubraokcu