Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Fix template command to not print list of deleted files #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimeh
Copy link

@jimeh jimeh commented Sep 23, 2019

For all wrapped Helm commands the list of decrypted files is printed as they get removed at the end of plugin execution. For the template command this is undesired, as it means you cannot simply run helm secrets template and get valid YAML output.

This change suppresses the output of deleted files for the template command only, meaning it does not alter the behavior of other commands, but just fixes the template command to work as I imagine most people would expect it to work.

Fixes issues #126 and #132.

For all wrapped Helm commands the list of decrypted files is printed as
they get removed at the end of plugin execution. For the `template`
command this is undesired, as it means you cannot simply run `helm
secrets template` and get valid YAML output.

This change suppresses the output of deleted files for the `template`
only, meaning it does not alter the behavior of other commands, but just
fixes the `template` command to work as I imagine most people would
expect it to work.

[Fixes issues zendesk#126 and zendesk#132]
@dev-kpyc
Copy link

dev-kpyc commented Oct 8, 2019

Can deletion output go to stderr instead?
In either case this should be merged

@jimeh
Copy link
Author

jimeh commented Oct 10, 2019

@dev-kpyc I'd say changes to the delete command's output should probably be a separate PR :)

@dev-kpyc
Copy link

@szibis

@lodotek
Copy link

lodotek commented Feb 17, 2020

Bump. Why has this not been approved yet? 👀

@rkt2spc
Copy link

rkt2spc commented Mar 23, 2020

Bump because it's been 5 months since this was pulled.

@mateuszzawisza can you help review this 🙏

@rkt2spc
Copy link

rkt2spc commented Aug 17, 2020

Any news? I've used the forked plugin over @jimeh repo and it seems to work fine. What are the blockers?

@jimbali
Copy link

jimbali commented Nov 24, 2020

When you get tired of an issue and go to fix it yourself, only to find that a former teammate of yours has already raised a PR for this 14 months ago that still hasn't been reviewed. 😂

@jimbali
Copy link

jimbali commented Dec 2, 2020

Hi @kaarolch, you were the last person to merge a PR. Are you available to review this please?

@rkt2spc
Copy link

rkt2spc commented Jan 5, 2021

@jimbali Use this fork instead https://github.com/jkroepke/helm-secrets (I'm using this on our production CD for 3 months already, no problem so far) this repo is dead

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants