feat: allow symfony 7 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
No, probably just an oversight. |
kbond
reviewed
Nov 16, 2023
|
Thanks @Chris53897! |
|
thanks @kbond |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by SymfonyTest/SymfonyDependencyInjectionTest#149 and by knplabs/knp-time-bundle https://github.com/KnpLabs/KnpTimeBundle/blob/main/composer.json#L20
Update: I created a PR: KnpLabs/KnpTimeBundle#202
Is there a reason that var-dumper version constraints are different from the others form symfony? https://github.com/zenstruck/messenger-monitor-bundle/compare/1.x...Chris53897:feature/allow-symfony-7?expand=1#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R38
zenstruck/console-test is bumped to 1.5 for a prefer-lowest run.