-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support set custom unmarshal row handle #4312
Open
changzzhou
wants to merge
5
commits into
zeromicro:master
Choose a base branch
from
changzzhou:feature/support_custom_unmarshal_row
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
support set custom unmarshal row handle #4312
changzzhou
wants to merge
5
commits into
zeromicro:master
from
changzzhou:feature/support_custom_unmarshal_row
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
支持自定义unmarshalRow&unmarshalRows方法
通过自定义unmarshalRow或者unmarshalRows方法,可以比较方便的来解析我们的struct,下面是个简单的例子 package main
import (
"database/sql"
"github.com/DATA-DOG/go-sqlmock"
"github.com/didi/gendry/scanner"
"github.com/stretchr/testify/assert"
"github.com/zeromicro/go-zero/core/stores/dbtest"
"github.com/zeromicro/go-zero/core/stores/sqlx"
"testing"
)
type User struct {
ID int64 `ddb:"id"`
Name string `ddb:"name"`
Age int `ddb:"age"`
Occupation *string `ddb:"occupation"`
}
func unmarshalRow(v any, rows *sql.Rows, strict bool) (err error) {
return scanner.Scan(rows, v)
}
func Test_unmarshalRow(t *testing.T) {
sqlx.SetUnmarshalRowHandler(unmarshalRow)
sqlx.SetUnmarshalRowsHandler(unmarshalRow)
dbtest.RunTest(t, func(db *sql.DB, mock sqlmock.Sqlmock) {
rs := sqlmock.NewRows([]string{"id", "name", "age", "occupation"}).AddRow(1, "Tom", 20, nil)
rs.AddRow(2, "Jerry", 22, sql.NullString{String: "engineer", Valid: true})
mock.ExpectQuery("select (.+) from users").WillReturnRows(rs)
conn := sqlx.NewSqlConnFromDB(db)
var users []*User
err := conn.QueryRow(&users, "select * from users")
assert.Nil(t, err)
assert.Equal(t, &User{ID: 1, Name: "Tom", Age: 20, Occupation: nil}, users[0])
occ := "engineer"
assert.Equal(t, &User{ID: 2, Name: "Jerry", Age: 22, Occupation: &occ}, users[1])
})
} |
Would it be too heavy to modify the global UnmarshalRowHandler of sqlx? And are there scenarios where both are needed? So, you can evaluate whether to follow the model and inject it into the option? |
…ngzzhou/go-zero into feature/support_custom_unmarshal_row
unmarshal row handler with option update test case
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持自定义unmarshalRow&unmarshalRows方法