Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow collections as type for the label attribute (fixes #315) #341

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Allow collections as type for the label attribute (fixes #315) #341

merged 2 commits into from
Feb 16, 2024

Conversation

Nahor
Copy link
Contributor

@Nahor Nahor commented Feb 16, 2024

No description provided.

@Nahor
feat(collection): add support for collection of labels (zkat#315)
6d01ca1 
Allow errors to have a number of labels determined at runtime.
An example of this is when the rust compiler labels all the arms of
a `match` expression when one of them has an incompatible type
@Nahor
feat(collection): allow LabeledSpan in label collections
7a54a9f 
To allow customization of the text for each label in a collection, add
support for using LabeledSpan in collections instead of just regular
spans
zkat
zkat approved these changes Feb 16, 2024
View reviewed changes
Copy link
Owner

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, this is really cool, so I'm not gonna pick on the syntax or whatever choices. It works and it's helpful/practical. Thanks so much!

@zkat zkat merged commit 0306024 into zkat:main Feb 16, 2024
14 checks passed
@Nahor Nahor deleted the collection branch February 16, 2024 03:06
@Nahor Nahor restored the collection branch February 16, 2024 03:22
@Nahor
Copy link
Contributor Author

Nahor commented Feb 16, 2024 •
edited
Loading

Nevermind, I didn't notice they were combined into one commit.
You merged only one of the two commit. Any issue with the other (to allow LabeledSpan in the collections, mainly to be able to set the text for each individual label in a collection, since one can't use macro attributes in that case)?

@Nahor Nahor deleted the collection branch February 16, 2024 03:29
@zkat
Copy link
Owner

zkat commented Feb 16, 2024

Yes, I squashed them. You're all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nahor @zkat