Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification templates initialization fix #397

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Notification templates initialization fix #397

merged 2 commits into from
Feb 22, 2024

Conversation

pboguslawski
Copy link
Contributor

Proposed change

Two youngest notifications ID 15 and ID 16 were introduced with e-mail template set to Default which is inconsistent with other e-mail notification templates in system. This mod fixes it (both notifications will initialize template same way as other notifications).

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Replaces: #100
Author-Change-Id: IB#1109073

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@pboguslawski
Notifications template initialization fix
6f57107 
New notifications ID 15 and ID 16 were introduced with e-mail template set to
Default which is inconsistent with other e-mail notification templates in
system. This mod fixes it (both notifications will initialize template same way
as other notifications).

Author-Change-Id: IB#1109073
@pboguslawski
Changelog removed
6e4588c 
Author-Change-Id: IB#1109073
@pboguslawski pboguslawski mentioned this pull request Apr 25, 2023
Closed
7 tasks
@dennykorsukewitz dennykorsukewitz added the 1 - 🐞 bug 🐞 An issue with the system. label Jun 9, 2023
@NiklasSchmitt
Copy link
Contributor

You are right. Set TransportEmailTemplate to Default via the initial data insert only for the two last added notification templates (id 15 &16) is not needed.

The Default value of TransportEmailTemplate is already set to Default (see https://github.com/znuny/Znuny/blob/dev/Kernel/System/Ticket/Event/NotificationEvent/Transport/Email.pm#L434) and will be stored in database while adding/editing a notification.

@NiklasSchmitt NiklasSchmitt added 4 - verified This issue or pull request was verified. 3 - wait for merge Znuny, it's your turn. labels Feb 19, 2024
@NiklasSchmitt NiklasSchmitt self-assigned this Feb 19, 2024
@NiklasSchmitt NiklasSchmitt merged commit 4cd26a7 into znuny:dev Feb 22, 2024
@NiklasSchmitt NiklasSchmitt removed the 3 - wait for merge Znuny, it's your turn. label Feb 22, 2024
@NiklasSchmitt NiklasSchmitt removed their assignment Feb 22, 2024
@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_16 milestone Feb 22, 2024
znuny-robo pushed a commit that referenced this pull request Feb 22, 2024
@pboguslawski @NiklasSchmitt
Removed initial insert of TransportEmailTemplate into table `notifi…
dd5143b 
…cation_event_item` for mention notification and ticket email delivery failure notification. (#397)
@pboguslawski pboguslawski deleted the dev-IB#1109073 branch March 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasSchmitt NiklasSchmitt NiklasSchmitt approved these changes

Assignees
No one assigned
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified.
Milestone
rel-7_0_16
Development

Successfully merging this pull request may close these issues.
3 participants
@pboguslawski @NiklasSchmitt @dennykorsukewitz