Rewrite using modern dependencies + dark theme + fixes #49
+8,183
−12,727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch from vidom to preact * Switch from tether-drop to floating-ui * Fix positioning issue when not many results * Move searching logic to a worker for even more responsive UI * More efficient style tooltips * Drop support for IE11 & Safari < 10.1 * Reduce bundle size
Also add aria-pressed attribute to signal that these are toggle buttons.
* Hide items instead of removing * Avoid re-rendering constant part of the StyleItem * Remove input debounce when user pastes value or clicks "Link" * Improve visual feedback while searching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
I tested this in Zotero to ensure correct dark/light mode matching. Also tested in older browsers (Safari 10, Edge 18), performance is obviously worse than in modern browsers, but acceptable and with good UI feedback.
Visually, there are some minor changes to make dark mode work. Colors are appropriated from Zotero theme. Despite this being a rewrite, produced DOM structure is very similar to what we had, except for accessibility fixes. Search logic is pretty-much untouched.