Create Qsam data set #109

sbollingerAtRocket · 2020-01-16T18:54:16Z

Signed-off-by: Steven Bollinger [email protected]

Signed-off-by: Steven Bollinger <[email protected]>

daveyc · 2020-01-17T06:54:18Z

c/datasetjson.c

+  }
+
+  /* Allocate structure in A31 space */
+  EXTF *bpxwdyn=(EXTF *)fetch("BPXWDYN");


There is no matching release() for this fetch.

Nothing that I have read has mentioned anything about releasing an item that has been fetched. What is your source for this?

The source is in the manual. It won't leak resources because the CDE has a use count but it's always good to clean up. You could stash the bpxwdyn pointer in a static variable and fetch it once. It will get released when the task ends.

Thanks for the info. None of the examples on bpxwdyn has the release function shown.

In fact, I'm not sure that it won't leak memory because there is a fetch control block associated with fetch used by LE. The underlying LOAD macro used by fetch is fine but I would still always call DELETE when I use a LOAD.

It's a fetch issue not related to BPXWDYN. fetch is is just a callable service.

But I would assume that any example showing how to use bpxwdyn would also show the release of the function since it already show the fetch of it.

Thanks, fixed

c/datasetjson.c

ifakhrutdinov · 2020-01-17T13:14:07Z

c/datasetjson.c

+  strncpy( below2G->request, baseRequest, sizeof(below2G->request));
+
+  /* Initialize the DD/FI field */
+  ptr = (request->ddName == NULL ?  QSAM_DEFAULT_DDNAME: request->ddName);


We already have code for dynalloc in https://github.com/zowe/zowe-common-c/blob/master/c/dynalloc.c, you should re-use/enhance code from there.

c/datasetjson.c

h/qsam.h

ifakhrutdinov · 2020-01-17T13:32:56Z

h/datasetjson.h

@@ -62,6 +63,7 @@ void respondWithDataset(HttpResponse* response, char* absolutePath, int jsonMode
 void respondWithVSAMDataset(HttpResponse* response, char* absolutePath, hashtable *acbTable, int jsonMode);
 void respondWithDatasetMetadata(HttpResponse *response);
 void respondWithHLQNames(HttpResponse *response, MetadataQueryCache *metadataQueryCache);
+int qsamAllocFile( qsamFileRequest *request, char* message, int messageLength);


There are no QSAM files or datasets, QSAM is an access method.

From earlier comment. I am open to any name change from qsam. Following names in the jira ticket.

@ifakhrutdinov is correct. I would name it allocDataSet which covers both PS and PDS(E) data sets.

Signed-off-by: Steven Bollinger <[email protected]>

1000TurquoisePogs · 2020-01-20T00:22:31Z

Steve noted that strtok used here is not thread safe, so tokenizing alternatives may be needed here.

ifakhrutdinov

I suggest we use SVC99 instead of passing commands and then parsing the results.

ifakhrutdinov · 2020-01-22T11:58:53Z

h/dynalloc.h

+  char   *expiration;
+  char   *spaceUnit;      /* BLKS, TRKS, CYCLS, KB, MB, BYTES */
+  int     dirBlk;
+  } dataSetRequest;


We start our own types with a capital letter.

ifakhrutdinov · 2020-01-22T12:01:37Z

h/dynalloc.h

+  char   *spaceUnit;      /* BLKS, TRKS, CYCLS, KB, MB, BYTES */
+  int     dirBlk;
+  } dataSetRequest;
+int allocDataSet( dataSetRequest *request, char* message, int messageLength);


Please remove the blank char between allocDataSet( and dataSetRequest *request,.

Is the content of message changed inside allocDataSet? If not, please use const.

Please use the dynalloc prefix for new functions.

I believe size_t would be more appropriate to represent a size.

ifakhrutdinov · 2020-01-22T12:05:06Z

c/dynalloc.c

+  }
+
+  /* Allocate structure in A31 space */
+  EXTF *bpxwdyn=(EXTF *)fetch("BPXWDYN");


This is not going to work in Metal C. Why not use the invokeSVC99 function?

ifakhrutdinov · 2020-01-22T12:06:29Z

c/dynalloc.c

@@ -29,6 +29,7 @@
 #include "zowetypes.h"
 #include "alloc.h"
 #include "dynalloc.h"
+#include "logging.h"


We're introducing a new dependency. Can we work out a different way of returning debug info? Perhaps return and reason codes.

ifakhrutdinov · 2020-01-22T12:07:22Z

c/dynalloc.c

+  strncpy(buffer, baseRequest, bufferSize);
+
+  /* Initialize the DD/FI field */
+  ptr = (request->ddName == NULL ?  DATASET_DEFAULT_DDNAME: request->ddName);


Please take a look at the existing functions in this file, they use a programmatic way to pass this information.

ifakhrutdinov · 2020-01-22T12:08:42Z

c/dynalloc.c

+  return status;
+}
+
+static void  allocDataSetCloseString(dataSetRequest *request, char *buffer,


What about reusing dynallocUnallocDatasetByDDName and the other unalloc functions?

ifakhrutdinov · 2020-01-22T12:20:01Z

c/dynalloc.c

+
+  /* Initialize organization */
+  if (request->organization != NULL) {
+    snprintf(field, sizeof(field)-1, "DSORG(%s) ", request->organization);


snprintf may fail

snprintf limit doesn't require a -1

ifakhrutdinov · 2020-01-22T12:22:25Z

c/dynalloc.c

+  /* Initialize record format */
+  if (request->recordFormat != NULL) {
+    snprintf(field, sizeof(field)-1, "RECFM(%s) ", request->recordFormat);
+    strncat(buffer, field, bufferSize - strlen(buffer));


if strlen(buffer) is greater than bufferSize, the result will wrap around, you'll get a huge positive number and a buffer overflow.

Create Qsam data set

1b059d7

Signed-off-by: Steven Bollinger <[email protected]>

daveyc reviewed Jan 17, 2020

View reviewed changes

ifakhrutdinov requested review from gadyck and ifakhrutdinov January 17, 2020 13:00

ifakhrutdinov requested changes Jan 17, 2020

View reviewed changes

Move functions to dynalloc. Change reference qsam to dataset

f24f268

Signed-off-by: Steven Bollinger <[email protected]>

ifakhrutdinov requested changes Jan 22, 2020

View reviewed changes

1000TurquoisePogs mentioned this pull request Jul 24, 2020

Edit a dataset zowe/zlux#498

Closed

John-A-Davies self-assigned this Aug 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Qsam data set #109

Create Qsam data set #109

sbollingerAtRocket commented Jan 16, 2020

daveyc Jan 17, 2020

sbollingerAtRocket Jan 17, 2020

daveyc Jan 17, 2020

sbollingerAtRocket Jan 17, 2020

daveyc Jan 17, 2020

daveyc Jan 17, 2020

sbollingerAtRocket Jan 17, 2020

sbollingerAtRocket Jan 17, 2020

ifakhrutdinov Jan 17, 2020

ifakhrutdinov Jan 17, 2020

sbollingerAtRocket Jan 17, 2020

daveyc Jan 17, 2020

1000TurquoisePogs commented Jan 20, 2020

ifakhrutdinov left a comment

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

ifakhrutdinov Jan 22, 2020

Create Qsam data set #109

Are you sure you want to change the base?

Create Qsam data set #109

Conversation

sbollingerAtRocket commented Jan 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1000TurquoisePogs commented Jan 20, 2020

ifakhrutdinov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment