Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for Dataset/Dataset Member Allocation #244

Open
wants to merge 16 commits into
base: v1.x/staging
Choose a base branch
from

Conversation

timgerstel
Copy link
Contributor

@timgerstel timgerstel commented Sep 24, 2021

This pull request implements the following feature:

  • API which enables the allocation of datasets and dataset members.
  • Add 'PUT' method to /datasetContents, accepts JSON body to specify dataset parameters
  • Sample request body:
{
   "ndisp": "CATALOG",
   "status": "NEW",
   "dsorg": "PS",
   "blksz": "27998",
   "lrecl": "84",
   "recfm": "V",
   "close": "true"
}

Tim Gerstel added 6 commits September 27, 2021 00:39
c/datasetjson.c Outdated Show resolved Hide resolved
c/dynalloc.c Outdated Show resolved Hide resolved
c/dynalloc.c Outdated Show resolved Hide resolved
c/datasetjson.c Outdated Show resolved Hide resolved
c/datasetjson.c Outdated Show resolved Hide resolved
c/datasetjson.c Outdated Show resolved Hide resolved
@lchudinov
Copy link
Contributor

lchudinov commented Oct 12, 2021

The code looks good to me now. I have a question: don't we need to unallocate the dataset? Did I miss the call that unallocated the dataset?

Copy link
Contributor

@lchudinov lchudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this because it's a new feature, but we need to deallocate the dataset at the end of the request.

@timgerstel timgerstel marked this pull request as ready for review November 3, 2021 15:16
@timgerstel timgerstel changed the title Feature/create ds API for Dataset/Dataset Member Allocation Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants