[experimental] Bugfix/warnings #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `int foo();` to `int foo(void);` Signed-off-by: Fyodor Kovin <[email protected]>
- changing `char *` to `void *` in alloc.c has long been a goal - also change the type for size from int to size_t, which is the type returned by the sizeof() operator, functions like strlen(), etc. Signed-off-by: Fyodor Kovin <[email protected]>
- functions like compareIgnoringCase() should really accept `const char *` and not `char *` because they don't modify their arguments. Not havingconst made it difficult to enforce const correctess in callers: the compiler would print warnings about casting const pointers to non-const pointers - functions like dumpbuffer() should really accept `const void *`, not `const char *` because that's the generic pointer type (since ANSI C89) This would also allow us to enable stricter compiler diagnostrics without seeing tons of irrelevant warnings about casting to `char *` Signed-off-by: Fyodor Kovin <[email protected]>
Signed-off-by: Fyodor Kovin <[email protected]>
ghost
assigned WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3438 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/bpxskt.c The variable "status" might be used before it is set. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/bpxskt.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "getCallersKey". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "getCallersKey". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "getCallersKey". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "getCallersKey". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "getCallersKey". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "getCallersKey". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/cmutils.c No function prototype given for "printf". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/collections.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/collections.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/collections.c Obsolete non-prototype-style function declaration. WARNING CCN3451 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/collections.c The target integral type cannot hold all possible values of the source integral type. WARNING CCN3451 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/collections.c The target integral type cannot hold all possible values of the source integral type. WARNING CCN3451 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/collections.c The target integral type cannot hold all possible values of the source integral type. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/crossmemory.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/crossmemory.c No function prototype given for "getLocalTimeOffset". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3426 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/dataservice.c An assignment expression is used as a condition. An equality comparison (==) may have been intended. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3438 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/datasetjson.c The variable "record" might be used before it is set. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/discovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/discovery.c No function prototype given for "getGDA". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "makeWSReadMachine". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "asciify". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "asciify". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "asciify". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "asciify". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "getFineGrainedTime". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "isLowerCasePasswordAllowed". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "isLowerCasePasswordAllowed". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "getFineGrainedTime". WARNING CCN3207 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c Integer constant (4096 * 1000000) is out of range. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "getFineGrainedTime". WARNING CCN3426 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c An assignment expression is used as a condition. An equality comparison (==) may have been intended. WARNING CCN3426 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c An assignment expression is used as a condition. An equality comparison (==) may have been intended. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpserver.c No function prototype given for "asciify". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/httpfileservice.c No function prototype given for "respondWithUnixFileNotFound". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/json.c No function prototype given for "write". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/le.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/le.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/le.c Obsolete non-prototype-style function declaration. ERROR CCN3343 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/le.c Redeclaration of initRLEEnvironment differs from previous declaration on line 332 of "/proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/le.h". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/le.c Obsolete non-prototype-style function declaration. WARNING CCN3451 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c The target integral type cannot hold all possible values of the source integral type. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c No function prototype given for "makeZoweAnchor". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/logging.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zos.c No function prototype given for "safVerifyInternal". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zos.c No function prototype given for "safVerifyInternal". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zos.c No function prototype given for "safVerifyInternal". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zos.c No function prototype given for "safVerifyInternal". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zos.c No function prototype given for "safVerifyInternal". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryContext". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "setDummyESPIE". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryRouterAddress". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryContext". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "deleteESTAEX". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryContext". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryContext". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getLatestState". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getLatestState". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getLatestState". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getLatestState". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryContext". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getRecoveryContext". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/recovery.c No function prototype given for "getLatestState". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/scheduling.c No function prototype given for "getLoggingContext". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/scheduling.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/stcbase.c No function prototype given for "zosPost". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/stcbase.c No function prototype given for "startRLETask". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/stcbase.c No function prototype given for "zosPost". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/stcbase.c No function prototype given for "startRLETask". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/stcbase.c No function prototype given for "zosPost". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/utils.c No function prototype given for "strncasecmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/utils.c No function prototype given for "incrementPlaceValues". WARNING CCN3426 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zosfile.c An assignment expression is used as a condition. An equality comparison (==) may have been intended. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zosfile.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zvt.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zvt.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zvt.c No function prototype given for "getZVTHandle". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zvt.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zvt.c No function prototype given for "getZVTHandle". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/c/zvt.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "makeInternalAPIMap". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c Obsolete non-prototype-style function declaration. ERROR CCN3099 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c Unexpected argument. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "initVersionComponents". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "initLoggingComponents". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileContentsService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileRenameService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileCopyService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileMakeDirectoryService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileTouchService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileMetadataService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installUnixFileTableOfContentsService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installVSAMDatasetContentsService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installDatasetMetadataService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installDatasetContentsService". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zss.c No function prototype given for "installOMVSService". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/serviceUtils.c No function prototype given for "memcpy". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/serviceUtils.c No function prototype given for "memcpy". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/authService.c No function prototype given for "strcasecmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/authService.c No function prototype given for "strcasecmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/authService.c No function prototype given for "strcasecmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/authService.c No function prototype given for "strcasecmp". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "getCharsetCode". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "getCharsetCode". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "strtoul". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithUnixFileNotFound". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithUnixFileNotFound". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/unixFileService.c No function prototype given for "respondWithUnixFileNotFound". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "respondWithJsonError". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". ERROR CCN3304 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/datasetService.c No function prototype given for "strcmp". WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/deps/zowe-common-c/h/bpxnet.h Obsolete non-prototype-style function declaration. WARNING CCN3450 /proj/kbm/pdkovi/src/zowe/2019-05-09/zss/c/zis/client.c Obsolete non-prototype-style function declaration. Signed-off-by: Fyodor Kovin <[email protected]>
fkovinAtRocket
force-pushed
the
bugfix/warnings
branch
4 times, most recently
from
dfe1667
to
94c64fb
Compare
- F_LOCK is an integer constant, the original struct name is `struct flock` - sleep is `uint sleep(uint)` not `void sleep(int)` - ntFunction is really an "umbrella" typedef for several different function signatures, so just define it with ... now Signed-off-by: Fyodor Kovin <[email protected]>
fkovinAtRocket
force-pushed
the
bugfix/warnings
branch
from
94c64fb
to
65c60f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a number of warnings here. This should allow us to compile ZSS with much stricter compiler diagnostics, thus seeing more problems at compile time. See the individual commits for description/motivation.
The basic idea is that if you enable strict diagnostics, you'll get:
The problem is that those false positives stop us from using the strict options all the time. This PR eliminates at least most common and trivial false positives.
I'm in the process of compiling ZSS with the actual strict options. That would lead to a lot more fixes, but those fixes would be more nuanced and requiring more effort to review.