implements zowe common logging format #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: E Kirschner <[email protected]>
|
zowe/zac#90 --> link to zowe common logging format |
| } | ||
| } | ||
| else if (compID >= LOG_PROD_ZIS && compID < LOG_PROD_ZSS) { | ||
| snprintf(prefix,5,"_zis"); |
There was a problem hiding this comment.
We need to know how well this works for zis
| break; | ||
| case 0xA0000: snprintf(suffix,10,"discovery"); | ||
| break; | ||
| case 0xB0000: snprintf(suffix,12,"dataservice"); |
There was a problem hiding this comment.
dataservice is here, yet unixfile is in zss, and neither restfile nor restdataservice are here, since I made them afterward. May want to revisit.
| else if (compID >= LOG_PROD_ZSS && compID < LOG_PROD_PLUGINS ) { | ||
| snprintf(prefix,5,"_zss"); | ||
| switch (id) { | ||
| case 0x10000: snprintf(suffix,11,"mvd_server"); |
There was a problem hiding this comment.
its not right to merge this when we have the perfect opportunity to rename it now before it becomes too visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: E Kirschner [email protected]