Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 pre-release Sept week 1 #3094

Merged
merged 6 commits into from
Sep 9, 2024
Merged

V3 pre-release Sept week 1 #3094

merged 6 commits into from
Sep 9, 2024

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Sep 5, 2024

Proposed changes

v3 Pre-release of changes from week 1 September 2024

Release Notes

Milestone: v3 pre-release

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Sep 5, 2024
@JillieBeanSim JillieBeanSim self-assigned this Sep 5, 2024
@JillieBeanSim JillieBeanSim added this to the v3 pre-releases milestone Sep 5, 2024
Signed-off-by: Billie Simmons <[email protected]>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (2389694) to head (586a7b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3094      +/-   ##
==========================================
- Coverage   92.73%   92.72%   -0.02%     
==========================================
  Files         113      113              
  Lines       11566    11566              
  Branches     2424     2553     +129     
==========================================
- Hits        10726    10724       -2     
- Misses        838      840       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/S labels Sep 5, 2024
@JillieBeanSim JillieBeanSim marked this pull request as ready for review September 5, 2024 19:58
@traeok
Copy link
Member

traeok commented Sep 6, 2024

Hey @JillieBeanSim, sorry for the last-minute notice but I was wondering if we could get one more PR into this pre-release?
I noticed an issue that caused our API calls to balloon in size. I did some in-depth testing last night and implemented a fix for it in #3093.

Update: Patch coverage is complete and the PR is ready for review.

Copy link

sonarcloud bot commented Sep 6, 2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great stuff being ported over as well as proper changelogs on the vNext branch 🥳
Thank you! 🙏🏽

LGTM! 😋

I'd love to include the PR below: but it may have to wait until the September week 2 prerelease.

@zFernand0 zFernand0 merged commit 6bc3179 into next Sep 9, 2024
14 checks passed
@zFernand0 zFernand0 deleted the v3-pre-release-sept5 branch September 9, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/L
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants