Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding added between the tooltip and the sidebar, Issue resolved, Fixes #1087 #1162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dishti-Oberai
Copy link
Collaborator

@Dishti-Oberai Dishti-Oberai commented Nov 10, 2021

Fixes #1087

This PR has added spacing between the tooltip and sidebar like tooltips of setting, reload, dnd and back button

All changes have been made in the main.css file in render folder in apps folder.

spacing between tooltip and sidebar
image
spacing between sidebar and tooltips of setting,reload,dnd and back button
image
Image of site
image

This PR has been tested on

  • Windows

@Signior-X
Copy link
Member

The changes look good to me, but the tests are failing.
Understand what the test says,
image

Instead of 0px, use 0 here.

Also, don't comment these.
image
Remove these lines if you don't want them in the PR.

@Dishti-Oberai
Copy link
Collaborator Author

Thank you @Signior-X,
I understood the error. Will look into it and make the necessary changes.

@zulipbot
Copy link
Member

Hello @Dishti-Oberai, it seems like you have referenced #1087 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #1087..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to Zulip!

@Dishti-Oberai Dishti-Oberai changed the title Padding added between the tooltip and the sidebar, Issue resolved Padding added between the tooltip and the sidebar, Issue resolved, Fixes #1087 Nov 20, 2021
@zulipbot
Copy link
Member

zulipbot commented Apr 9, 2022

Heads up @Dishti-Oberai, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No spacing between tooltips of organisations.
3 participants