Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: improved visibility of toggle buttons #1377

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Axshatt
Copy link

@Axshatt Axshatt commented Jul 9, 2024

Fixes issue #1357

What's this PR do?
This PR Improves the toggle button and text visibility in the settings page.

Screenshots:

Before :
image
After :
image

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

Desktop :

Operating System: Windows 11
Zulip Desktop v5.11.0

@alya
Copy link
Collaborator

alya commented Jul 9, 2024

Thanks! Can you describe how this differs from #1367? It may be best to review the work there rather than opening a new PR.

@Axshatt
Copy link
Author

Axshatt commented Jul 10, 2024

There is a slight change from the #1367. The nav headers were not similar to the other texts.

Screenshots
image

image

So, I changed the font color similar to the other fonts. rgb( 0 0 0 /100%)
Provide me with more feedback to make this more user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants