UI: Reconnect network page imporved. #996
Conversation
|
Checkout comments on #872. Try to find some graphics or maybe change the background color - a darker colour which could say there is connectivity error !?! |
Yeah i had read it. should i make the background darker ? because using any random image from internet could lead to copyright issue that is the reason i preferred using the old one. |
|
@samyakgaur before opening a PR please discuss the approach, UI changes etc with the community on czo. This will save a lot of your time. |
Yes @akashnimare i had done that but didn’t get any reply so i moved forward with this approach. Not an issue ill ask once again :) |
There was a problem hiding this comment.
Thanks for the PR, @samyakgaur! Left a couple of nitpicky comments, nothing major - but please do follow @akashnimare's advice and save everyone a lot of time by discussing things before you implement them.
samyakgaur
force-pushed
the
networkpage
branch
2 times, most recently
from
a131dbf
to
93c3b81
Compare
|
@samyakgaur are you up for making the above changes? Once done, we can merge. |
@akashnimare sorry, almost forgot about this PR. will make the following changes and commit it. |
Fixes zulip#862. Center aligned the text and added a table to make points look better.Div tags are changed to button tag and mobile comptaibility added.
samyakgaur
force-pushed
the
networkpage
branch
from
422ef18
to
5dcff9b
Compare
|
Heads up @samyakgaur, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
What's this PR do?
Improves the design alignment of network reconnect page.
Any background context you want to provide?
Fixes #862
Screenshots?
You have tested this PR on: