Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureQueries async #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FutureQueries async #132

wants to merge 2 commits into from

Conversation

israellot
Copy link

Async implementation of FutureQueries.
Triggered when ToListAsync is called or Value is awaited for FutureValue.

@israellot
Copy link
Author

I'm sorry I pulled the wrong version. It's incomplete.

@israellot
Copy link
Author

Now it's complete.

@marius-stanescu
Copy link

I think the following line needs to be changed:

var result = GetResultAsync().Result?? Enumerable.Empty<T>();

Result can easily cause deadlock in async code in certain scenarios. More info here.

@lcornejo
Copy link

@israellot looks like the appVeryor build is not working, seems like its targeting net40, shouldn't it target 4.5+?

@pwelter34 any update on merging this?

@israellot
Copy link
Author

Long time since I don´t look at this. My workaround is running in production for over a year now.

@AdamMachera
Copy link

@israellot do you know when it is planned to be merged into main branch?

@MeTitus
Copy link

MeTitus commented Sep 27, 2016

Is this project dead?

@DzheiZee DzheiZee mentioned this pull request Nov 28, 2016
@DzheiZee
Copy link
Contributor

Check it out.
#230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants