Bump nokogiri to 1.11.0 #183
Conversation
|
|
tancnle
force-pushed
the
bump-nokogiri-1-11-0
branch
from
0694a18
to
594236d
Compare
| if RUBY_VERSION.start_with?("2.3") then | ||
| gem "nokogiri", "~> 1.10.4", :require => false | ||
| gem "nokogiri", "~> 1.10.4", :require => false | ||
| else | ||
| gem "nokogiri", "~> 1.11.0.rc2", :require => false | ||
| gem "nokogiri", "~> 1.11.0", :require => false | ||
| end |
There was a problem hiding this comment.
@tancnle nokogiri dropped Ruby 2.4 support at 1.1.0.rc4. So you need to enforce 1.11.0 on 2.4 somehow, or you need to put a branch for 2.4 between if and else:
elif RUBY_VERSION.start_with("2.4") then
gem "nokogiri", "~> 1.11.0.rc2", :require => falseThere was a problem hiding this comment.
@onlined Excellent point 👍. That was an oversight on my part. Adding an additional branch to handle 2.4 is definitely doable. However, given the Ruby 2.4 support drop, I don't think this PR is adding much value (i.e. users can still lock the preferred nokogiri version given their Ruby version constraint).
If there is any plan to drop support for 2.4 altogether as it is EOL'ed and soon 2.5 (https://www.ruby-lang.org/en/downloads/), we can remove these conditionals and cut a major version bump of this gem. IMHO, that would be a more preferable approach.
tancnle
force-pushed
the
bump-nokogiri-1-11-0
branch
from
594236d
to
595fbab
Compare
Bump
nokogirigem to1.11.0Release note:
https://github.com/sparklemotion/nokogiri/blob/007662fc216902a5ae186cb78b0d46f7f48b8d92/CHANGELOG.md#v1110--2021-01-03